Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate proto codegen tool from https://github.com/nspcc-dev/neofs-api-go #675

Open
cthulhu-rider opened this issue Dec 27, 2024 · 1 comment
Labels
feature Completely new functionality I4 No visible changes S2 Regular significance U2 Seriously planned

Comments

@cthulhu-rider
Copy link
Contributor

https://github.com/nspcc-dev/neofs-api-go/tree/master/util/protogen was previously used. It's worth to migrate here with proper adoption: interfaces changed a bit, generics came into the game

make sure unit tests are max deep before, any mistakes in "stable" marshaling are critical. If they are not deep enough - increase coverage. I had several thoughts about this, will share a bit later

@cthulhu-rider cthulhu-rider added the enhancement Improving existing functionality label Dec 27, 2024
@roman-khimov
Copy link
Member

  1. Just transfer.
  2. Separate issue for generics and any other magic.

@roman-khimov roman-khimov added U2 Seriously planned S2 Regular significance I4 No visible changes feature Completely new functionality and removed enhancement Improving existing functionality labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Completely new functionality I4 No visible changes S2 Regular significance U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants