Skip to content
This repository has been archived by the owner on Oct 3, 2021. It is now read-only.

The layout problem #1

Open
lateef-k opened this issue Nov 28, 2019 · 1 comment
Open

The layout problem #1

lateef-k opened this issue Nov 28, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@lateef-k
Copy link
Collaborator

Below is the code responsible for figuring out the layout for the canvases. We first see how many canvases we need by looking at seqVizPairs.length and then we calculate the size of each canvas so as to distribute them as equally as possible.

https://github.com/katestange/Numberscope/blob/1eeafb6f7bda937036e0a76b250515779f78485d/website/javascript/NScore.js#L141-L146

The div where the canvas will be placed is then created in the NScore.generateP5 method,

https://github.com/katestange/Numberscope/blob/1eeafb6f7bda937036e0a76b250515779f78485d/website/javascript/NScore.js#L34-L39

and then we call the create the canvas itself in the following line

https://github.com/katestange/Numberscope/blob/1eeafb6f7bda937036e0a76b250515779f78485d/website/javascript/NScore.js#L45

the divs are styled in these lines in the toolPage.css file

https://github.com/katestange/Numberscope/blob/1eeafb6f7bda937036e0a76b250515779f78485d/website/css/toolPage.css#L67-L80

There are a few problems:

  • Using the browser while not maximized leads to weird behavior.
  • Everything looks so much bigger on chrome
  • Canvases overflow slightly on bottom side and the right side.

I almost certain this is a CSS issue, which I'm terrible at.

@lateef-k lateef-k added the bug Something isn't working label Nov 28, 2019
@lateef-k
Copy link
Collaborator Author

this (68b86d8) commit didn't actually fix the chrome layout issue, I was just zoomed out....
the chrome layout still looks kinda super zoomed in.

ghost pushed a commit that referenced this issue Feb 10, 2020
Creation of base application
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant