Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New e15 clipboard simulator doesn't handle well CRLF #1796

Open
RedGl0w opened this issue Mar 5, 2021 · 4 comments · May be fixed by #1797
Open

New e15 clipboard simulator doesn't handle well CRLF #1796

RedGl0w opened this issue Mar 5, 2021 · 4 comments · May be fixed by #1797
Milestone
Version 17

Comments

@RedGl0w
Copy link
Contributor

RedGl0w commented Mar 5, 2021 •
edited
Loading

Describe the bug

When using windows for instance, and browsing on the web simulator, when we paste a string from the clipboard, the CR aren't removed (because epsilon is made for LF).

Screenshots

From @cent20net
image

Expected behavior

To remove CRLF from the clipboard

Environment

  • Epsilon 15
  • The platform(s) on which the problem happens: simulator (windows and web on windows)
@nsi-xyz
Copy link

nsi-xyz commented Mar 5, 2021

Bonjour,

Ce matin j'ai voulu tester la fonctionnalité "sauvegarde de l'état" et partage de celui-ci via un lien court 😍
C'est d'ailleurs mieux que ce que l'on avait demandé :
#1556
Merci à l'équipe pour ce développement intéressant.

J'ai donc pris un script :
https://workshop.numworks.com/python/cent20/nsi4ever
Je l'ai copié collé dans l'émulateur web
J'ai généré le lien court
https://workshop.numworks.com/simulators/1vy9pia
https://workshop.numworks.com/simulators/da3jn
Et il n'y avait pas mon script 😒

Merci à @RedGl0w pour la version EN de ce bug.

@RedGl0w RedGl0w linked a pull request Mar 5, 2021 that will close this issue
Open
@RedGl0w
Copy link
Contributor Author

RedGl0w commented Mar 5, 2021

J'ai donc pris un script :
https://workshop.numworks.com/python/cent20/nsi4ever
Je l'ai copié collé dans l'émulateur web
J'ai généré le lien court
https://workshop.numworks.com/simulators/1vy9pia
https://workshop.numworks.com/simulators/da3jn
Et il n'y avait pas mon script unamused

Indeed, the bug you're reporting is totally different. The new system of recording session on the web simulator is a bit special : it record keypresses, and when you open the link given by the website, it "press" it instantly, so the paste event won't work when storing the session (that would need to change a bit how the new system works, and every copy / paste event, store in the Module.ionEvents with the event, the content of the clipboard).

@artaxxx artaxxx added this to the Version 17 milestone Mar 10, 2021
@RedGl0w
Copy link
Contributor Author

RedGl0w commented May 6, 2021

Bonjour,

Ce matin j'ai voulu tester la fonctionnalité "sauvegarde de l'état" et partage de celui-ci via un lien court 😍
C'est d'ailleurs mieux que ce que l'on avait demandé :
#1556
Merci à l'équipe pour ce développement intéressant.

J'ai donc pris un script :
https://workshop.numworks.com/python/cent20/nsi4ever
Je l'ai copié collé dans l'émulateur web
J'ai généré le lien court
https://workshop.numworks.com/simulators/1vy9pia
https://workshop.numworks.com/simulators/da3jn
Et il n'y avait pas mon script 😒

Merci à @RedGl0w pour la version EN de ce bug.

After having looked at how this new session system is done in epsilon, you should probably open an issue (because it is in epsilon :p). If you want I can do it for you

@nsi-xyz
Copy link

nsi-xyz commented May 6, 2021

After having looked at how this new session system is done in epsilon, you should probably open an issue (because it is in epsilon :p). If you want I can do it for you

Voilà, on fait comme ça ! 😁

@RedGl0w RedGl0w mentioned this issue May 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 17
Development

Successfully merging a pull request may close this issue.

[Ion/clipboard] Remove CR when there's LF next RedGl0w/epsilon
3 participants
@artaxxx @RedGl0w @nsi-xyz