Strange snaked versions of pluralized acronyms

[rowanseymour]

I don't know how safe it would be to tinker with CamelToSnake now but DisallowedIPs snakes to disallowed_i_ps so the Mailroom env variable is MAILROOM_DISALLOWED_I_PS

[rowanseymour]

Guess it's fine if we make a v2 🤷

[nicpottier]

Heh, ya, that's a funny one. I'm not sure any strategy is always going to be right. Shouldn't that variable be DisallowedSubnets anyways? :)

[nicpottier]

All that said, I can't really think of any other cases of plural acronyms but I suppose special casing that wouldn't be the worst thing in the world. Alternatively we could add a tag to let the user explicitly pick their snake case.

[rowanseymour]

I think I'd lean toward a tag rather than try to be too clever... the algorithm is correct for other (contrived) examples that happen to not be acronyms.. e.g. ThingsThatIBe

DisallowedSubnets doesn't feel ideal for a list of IP addresses and IP ranges... but I'm convincing myself to rename that variable anyway because DisallowedIPs isn't very self-explanatory.

[nicpottier]

DisallowedNetworks is maybe most correct? (with us being smart and working it you leave off the netmask?)

[rowanseymour]

Not sure I follow what you mean by leaving off the netmask.. it's a list of IP addresses and IP blocks defined by address+mask

[nicpottier]

I'm saying a "network" usually is IP + netmask, so while using the term network wouldn't be technically correct for IPs we could ask for forgiveness.

[rowanseymour]

Ah ok - am gonna rename to DisallowedNetworks so we can get on with life, and if anyone is bored one day they can add support for a conf tag to specify snakification 👍