Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RO:0012008 was added to March 2021 release but did not have a definition #436

Closed
cthoyt opened this issue Mar 8, 2021 · 4 comments
Closed

RO:0012008 was added to March 2021 release but did not have a definition #436

cthoyt opened this issue Mar 8, 2021 · 4 comments

Comments

@cthoyt
Copy link
Collaborator

cthoyt commented Mar 8, 2021

I think it would be agreeable that all Typedef and Term stanzas should have a definition - I just noticed this one since there was a new release (and it did not get flagged as a blocker for release...)

Originally posted by @cthoyt in #435 (comment)
@matentzn
Copy link
Contributor

matentzn commented Mar 8, 2021

I agree with @cthoyt. I think RO relations absolutely must have a proper definition - else it will be exceedingly easy to misuse them.. These are the ones ROBOT report flags up.

WARN	missing_definition	BFO:0000002	IAO:0000115	
WARN	missing_definition	BFO:0000003	IAO:0000115	
WARN	missing_definition	BFO:0000015	IAO:0000115	
WARN	missing_definition	BFO:0000050	IAO:0000115	
WARN	missing_definition	BFO:0000051	IAO:0000115	
WARN	missing_definition	BFO:0000062	IAO:0000115	
WARN	missing_definition	BFO:0000063	IAO:0000115	
WARN	missing_definition	BFO:0000066	IAO:0000115	
WARN	missing_definition	CARO:0000006	IAO:0000115	
WARN	missing_definition	GO:0004842	IAO:0000115	
WARN	missing_definition	GO:0016301	IAO:0000115	
WARN	missing_definition	GO:0044403	IAO:0000115	
WARN	missing_definition	GO:0072519	IAO:0000115	
WARN	missing_definition	GO:0085030	IAO:0000115	
WARN	missing_definition	GO:0085031	IAO:0000115	
WARN	missing_definition	RO:0000052	IAO:0000115	
WARN	missing_definition	RO:0000057	IAO:0000115	
WARN	missing_definition	RO:0001000	IAO:0000115	
WARN	missing_definition	RO:0001001	IAO:0000115	
WARN	missing_definition	RO:0001018	IAO:0000115	
WARN	missing_definition	RO:0001019	IAO:0000115	
WARN	missing_definition	RO:0001025	IAO:0000115	
WARN	missing_definition	RO:0002000	IAO:0000115	
WARN	missing_definition	RO:0002001	IAO:0000115	
WARN	missing_definition	RO:0002002	IAO:0000115	
WARN	missing_definition	RO:0002005	IAO:0000115	
WARN	missing_definition	RO:0002006	IAO:0000115	
WARN	missing_definition	RO:0002016	IAO:0000115	
WARN	missing_definition	RO:0002017	IAO:0000115	
WARN	missing_definition	RO:0002022	IAO:0000115	
WARN	missing_definition	RO:0002081	IAO:0000115	
WARN	missing_definition	RO:0002082	IAO:0000115	
WARN	missing_definition	RO:0002083	IAO:0000115	
WARN	missing_definition	RO:0002084	IAO:0000115	
WARN	missing_definition	RO:0002085	IAO:0000115	
WARN	missing_definition	RO:0002086	IAO:0000115	
WARN	missing_definition	RO:0002087	IAO:0000115	
WARN	missing_definition	RO:0002088	IAO:0000115	
WARN	missing_definition	RO:0002089	IAO:0000115	
WARN	missing_definition	RO:0002090	IAO:0000115	
WARN	missing_definition	RO:0002091	IAO:0000115	
WARN	missing_definition	RO:0002092	IAO:0000115	
WARN	missing_definition	RO:0002093	IAO:0000115	
WARN	missing_definition	RO:0002111	IAO:0000115	
WARN	missing_definition	RO:0002159	IAO:0000115	
WARN	missing_definition	RO:0002222	IAO:0000115	
WARN	missing_definition	RO:0002223	IAO:0000115	
WARN	missing_definition	RO:0002224	IAO:0000115	
WARN	missing_definition	RO:0002229	IAO:0000115	
WARN	missing_definition	RO:0002230	IAO:0000115	
WARN	missing_definition	RO:0002287	IAO:0000115	
WARN	missing_definition	RO:0002297	IAO:0000115	
WARN	missing_definition	RO:0002300	IAO:0000115	
WARN	missing_definition	RO:0002301	IAO:0000115	
WARN	missing_definition	RO:0002304	IAO:0000115	
WARN	missing_definition	RO:0002305	IAO:0000115	
WARN	missing_definition	RO:0002312	IAO:0000115	
WARN	missing_definition	RO:0002322	IAO:0000115	
WARN	missing_definition	RO:0002326	IAO:0000115	
WARN	missing_definition	RO:0002327	IAO:0000115	
WARN	missing_definition	RO:0002343	IAO:0000115	
WARN	missing_definition	RO:0002344	IAO:0000115	
WARN	missing_definition	RO:0002354	IAO:0000115	
WARN	missing_definition	RO:0002360	IAO:0000115	
WARN	missing_definition	RO:0002405	IAO:0000115	
WARN	missing_definition	RO:0002408	IAO:0000115	
WARN	missing_definition	RO:0002409	IAO:0000115	
WARN	missing_definition	RO:0002423	IAO:0000115	
WARN	missing_definition	RO:0002424	IAO:0000115	
WARN	missing_definition	RO:0002425	IAO:0000115	
WARN	missing_definition	RO:0002426	IAO:0000115	
WARN	missing_definition	RO:0002435	IAO:0000115	
WARN	missing_definition	RO:0002444	IAO:0000115	
WARN	missing_definition	RO:0002445	IAO:0000115	
WARN	missing_definition	RO:0002447	IAO:0000115	
WARN	missing_definition	RO:0002453	IAO:0000115	
WARN	missing_definition	RO:0002455	IAO:0000115	
WARN	missing_definition	RO:0002456	IAO:0000115	
WARN	missing_definition	RO:0002457	IAO:0000115	
WARN	missing_definition	RO:0002459	IAO:0000115	
WARN	missing_definition	RO:0002460	IAO:0000115	
WARN	missing_definition	RO:0002461	IAO:0000115	
WARN	missing_definition	RO:0002462	IAO:0000115	
WARN	missing_definition	RO:0002463	IAO:0000115	
WARN	missing_definition	RO:0002464	IAO:0000115	
WARN	missing_definition	RO:0002465	IAO:0000115	
WARN	missing_definition	RO:0002466	IAO:0000115	
WARN	missing_definition	RO:0002467	IAO:0000115	
WARN	missing_definition	RO:0002468	IAO:0000115	
WARN	missing_definition	RO:0002469	IAO:0000115	
WARN	missing_definition	RO:0002470	IAO:0000115	
WARN	missing_definition	RO:0002471	IAO:0000115	
WARN	missing_definition	RO:0002481	IAO:0000115	
WARN	missing_definition	RO:0002482	IAO:0000115	
WARN	missing_definition	RO:0002483	IAO:0000115	
WARN	missing_definition	RO:0002485	IAO:0000115	
WARN	missing_definition	RO:0002486	IAO:0000115	
WARN	missing_definition	RO:0002487	IAO:0000115	
WARN	missing_definition	RO:0002502	IAO:0000115	
WARN	missing_definition	RO:0002506	IAO:0000115	
WARN	missing_definition	RO:0002535	IAO:0000115	
WARN	missing_definition	RO:0002536	IAO:0000115	
WARN	missing_definition	RO:0002537	IAO:0000115	
WARN	missing_definition	RO:0002538	IAO:0000115	
WARN	missing_definition	RO:0002549	IAO:0000115	
WARN	missing_definition	RO:0002550	IAO:0000115	
WARN	missing_definition	RO:0002555	IAO:0000115	
WARN	missing_definition	RO:0002556	IAO:0000115	
WARN	missing_definition	RO:0002557	IAO:0000115	
WARN	missing_definition	RO:0002559	IAO:0000115	
WARN	missing_definition	RO:0002563	IAO:0000115	
WARN	missing_definition	RO:0002564	IAO:0000115	
WARN	missing_definition	RO:0002574	IAO:0000115	
WARN	missing_definition	RO:0002580	IAO:0000115	
WARN	missing_definition	RO:0002585	IAO:0000115	
WARN	missing_definition	RO:0002587	IAO:0000115	
WARN	missing_definition	RO:0002588	IAO:0000115	
WARN	missing_definition	RO:0002590	IAO:0000115	
WARN	missing_definition	RO:0002591	IAO:0000115	
WARN	missing_definition	RO:0002611	IAO:0000115	
WARN	missing_definition	RO:0002616	IAO:0000115	
WARN	missing_definition	RO:0002618	IAO:0000115	
WARN	missing_definition	RO:0002619	IAO:0000115	
WARN	missing_definition	RO:0002622	IAO:0000115	
WARN	missing_definition	RO:0002623	IAO:0000115	
WARN	missing_definition	RO:0002624	IAO:0000115	
WARN	missing_definition	RO:0002625	IAO:0000115	
WARN	missing_definition	RO:0002626	IAO:0000115	
WARN	missing_definition	RO:0002627	IAO:0000115	
WARN	missing_definition	RO:0002634	IAO:0000115	
WARN	missing_definition	RO:0002635	IAO:0000115	
WARN	missing_definition	RO:0004000	IAO:0000115	
WARN	missing_definition	RO:0004001	IAO:0000115	
WARN	missing_definition	RO:0004002	IAO:0000115	
WARN	missing_definition	RO:0004003	IAO:0000115	
WARN	missing_definition	RO:0004004	IAO:0000115	
WARN	missing_definition	RO:0004005	IAO:0000115	
WARN	missing_definition	RO:0004006	IAO:0000115	
WARN	missing_definition	RO:0004010	IAO:0000115	
WARN	missing_definition	RO:0004017	IAO:0000115	
WARN	missing_definition	RO:0004018	IAO:0000115	
WARN	missing_definition	RO:0004019	IAO:0000115	
WARN	missing_definition	RO:0004023	IAO:0000115	
WARN	missing_definition	RO:0004025	IAO:0000115	
WARN	missing_definition	RO:0004032	IAO:0000115	
WARN	missing_definition	RO:0004033	IAO:0000115	
WARN	missing_definition	RO:0004046	IAO:0000115	
WARN	missing_definition	RO:0004047	IAO:0000115	
WARN	missing_definition	RO:0004049	IAO:0000115	
WARN	missing_definition	RO:0004050	IAO:0000115	
WARN	missing_definition	RO:0012008	IAO:0000115	
WARN	missing_definition	RO:HOM0000000	IAO:0000115	
WARN	missing_definition	RO:HOM0000001	IAO:0000115	
WARN	missing_definition	RO:HOM0000003	IAO:0000115

We can either try to make an effort to retrofit these definitions, or inject stubs - that way, be relations added will be flagged up as missing (and we can fail on missing definition).

@cthoyt
Copy link
Collaborator Author

cthoyt commented Mar 8, 2021

@matentzn this is another reason I'm a big fan of using ORCID ids (or related) for created_by -> then we could ping the original author for each

@matentzn
Copy link
Contributor

matentzn commented Mar 8, 2021

information-artifact-ontology/ontology-metadata#60

@balhoff
Copy link
Member

balhoff commented Jun 1, 2021

We discussed at June 1 meeting, @matentzn will another issue about a more detailed form for new submissions which will require providing a definition for any new relations.

@balhoff balhoff closed this as completed Jun 1, 2021
@matentzn matentzn mentioned this issue Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@balhoff @cthoyt @matentzn