Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Nmap #5206

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add plugin: Nmap #5206

wants to merge 4 commits into from

Conversation

Yasha-ops
Copy link

@Yasha-ops Yasha-ops commented Jan 20, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Yasha-ops/obsidian-nmap-plugin

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ Could not parse community-plugins.json, invalid JSON. Expected double-quoted property name in JSON at position 546063


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."per"
},
]
" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ Unable to find a release with the tag 0.2.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Yasha-ops Yasha-ops changed the title Add plugin: Nmaper Add plugin: Nmaper Jan 21, 2025
@Yasha-ops Yasha-ops closed this Jan 21, 2025
@Yasha-ops Yasha-ops reopened this Jan 21, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Yasha-ops Yasha-ops closed this Jan 21, 2025
@Yasha-ops Yasha-ops reopened this Jan 21, 2025
@github-actions github-actions bot changed the title Add plugin: Nmaper Add plugin: Nmaper Jan 21, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 21, 2025
Change name of plugin
@Yasha-ops Yasha-ops changed the title Add plugin: Nmaper Add plugin: Nmap Jan 21, 2025
@joethei
Copy link
Collaborator

joethei commented Jan 21, 2025

Please follow the pull request template fully, don't just copy & paste the thing the bot is using for the check to evade it.

@Yasha-ops
Copy link
Author

Please follow the pull request template fully, don't just copy & paste the thing the bot is using for the check to evade it.

I don't get it ? I have just changed the name of the plugin :(

@Yasha-ops
Copy link
Author

Please follow the pull request template fully, don't just copy & paste the thing the bot is using for the check to evade it.

And i have added a Licence file in the repo :(

@joethei
Copy link
Collaborator

joethei commented Jan 21, 2025

Read your initial message in this PR.
You are supposed to click one of the links when creating the PR, then the text field will populate with this: https://github.com/obsidianmd/obsidian-releases/blob/master/.github/PULL_REQUEST_TEMPLATE/plugin.md?plain=1

Please copy & paste this into your initial message and fill it.

@Yasha-ops
Copy link
Author

Please follow the pull request template fully, don't just copy & paste the thing the bot is using for the check to evade it.

And i have added a Licence file in the repo :(

Read your initial message in this PR. You are supposed to click one of the links when creating the PR, then the text field will populate with this: https://github.com/obsidianmd/obsidian-releases/blob/master/.github/PULL_REQUEST_TEMPLATE/plugin.md?plain=1

Please copy & paste this into your initial message and fill it.

Ohhh my bad ! My computer has blocked the link the first time ! Thank you :D

@Yasha-ops Yasha-ops closed this Jan 21, 2025
@Yasha-ops Yasha-ops reopened this Jan 21, 2025
@Yasha-ops
Copy link
Author

Read your initial message in this PR. You are supposed to click one of the links when creating the PR, then the text field will populate with this: https://github.com/obsidianmd/obsidian-releases/blob/master/.github/PULL_REQUEST_TEMPLATE/plugin.md?plain=1

Please copy & paste this into your initial message and fill it.

Should i do something else to validate my plugin ? 😄

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jan 21, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 21, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants