Make -lgcc_eh on mingw-w64 optional
#147
Conversation
Some configurations of mingw-w64 gcc don't use -lgcc_eh - treat it as an optional library.
|
@toots - no particular rush, but if you have a chance to confirm that this allows the patch you carry in opam-cross-windows to be removed, that'd be great. |
|
Hi @dra27. The changes in ocaml/ocaml#12996 are actually the patch used by the cross-compiler so it can already be dropped. I'm not sure that I understand the difference with this PR or what additional change this PR is doing? |
|
Ah, have I misunderstood the problem - I thought the issue was that there wasn't any |
|
Isn't this patch https://github.com/ocaml-cross/opam-cross-windows/blob/main/packages/flexdll-windows/flexdll-windows.0.42/files/patches/no-gcc_eh.patch still in use, though? |
Ho, different one! I was looking at the patch on OCaml: https://github.com/ocaml-cross/opam-cross-windows/blob/main/packages/ocaml-windows64/ocaml-windows64.5.1.1/files/patches/configure.patch Then, yes, this looks like it will allow us to remove the patch on flexdll. I should be able to test this soon, thanks! |
Should fix #133. As noted in ocaml/ocaml#12996, there are configurations where
-lgcc_ehisn't available (and therefore required). The change is simply to resolve-lgcc_ehand only add it todefault_libsif it's actually found - although it's a slightly noisier change than that simplicity implies!