-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msvc, mingw: do not use cygpath by default #140
Conversation
f65f3ea
to
45f89d2
Compare
bf4b5a7
to
8372a50
Compare
The |
The mingw-w64 port under Cygwin definitely needs to do this to parse
and on MSYS2:
I haven't checked the history, but I think that the behaviour may have been different way back in the early days when the mingw port was accessed with I think the best behaviour might be:
I think all the pieces are in place for the second part, but for now a quick fix would just be to do the first (it's obviously unequivocally wrong to be calling cygpath for MSVC). |
Thanks for the quick review (on a weekend) :)
OK, I did this. |
I'm still dithering over whether this is the right thing to do (versus updating the documentation!). What I'm wondering is whether there are any MSVC users out there (compiling in Cygwin - i.e. using Unix-like infrastructure) where they do end up passing Cygwin-style paths (e.g. for |
Makes sense; probably updating the documentation is the way to go. A bit underwater at the moment though, so closing this for the time being :) Thanks! |
The default value of
use_cygpath
isTry
, contrary to what the help stringflexdll/cmdline.ml
Line 150 in a60821e
Fixes #139