Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldebug.el load time (cond (window-system)) incompatible with emacs server #212

Open
SkySkimmer opened this issue Jul 2, 2019 · 2 comments
Assignees

Comments

@SkySkimmer
Copy link
Contributor

SkySkimmer commented Jul 2, 2019

In ocamldebug.el there's a conditional on window-system at load time

tuareg/ocamldebug.el

Lines 75 to 76 in c81413b

(cond
(window-system

If emacs is started with --daemon and tuareg loaded by the user's init.el, and then the user opens a GUI client frame, the conditional will have produced incorrect results.
At the user level this may manifest as "incorrect arguments (overlayp)" process filter error messages, strange slowness when sending commands, and lack of underlining in the source file (perhaps not exhaustive).

@Chris00 Chris00 self-assigned this Jul 3, 2019
monnier added a commit that referenced this issue Jul 9, 2019
#212)

(ocamldebug-overlay-event, ocamldebug-overlay-under)
(ocamldebug-event-marker): Initialize in the declaration.
(ocamldebug-event, ocamldebug-underline): Define with `defface`.
@monnier
Copy link
Contributor

monnier commented Jul 9, 2019 via email

@Chris00
Copy link
Member

Chris00 commented Jul 10, 2019

@monnier Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants