Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Setting collectWindowErrors to false stops handled errors from reporting #41

Open
nazjunaid opened this issue Apr 5, 2013 · 4 comments

Comments

@nazjunaid
Copy link

I have an example here http://jsfiddle.net/tGZGW/

It's based of the current master code.

@devinrhode2
Copy link

It's new, but I recommend you try using this: https://github.com/devinrhode2/shield.js/blob/master/src/shield.js

Just define a onuncaughtException function that takes in one parameter, e, the exception from catch. Wrap your program code with the shield function as described in the inline docs there, and you should be good. You can then JSON.serialize the object, or pass it to an analytics library and just have it fill into your analytics dashboard

Please let me know how that goes for you.

@occ
Copy link
Owner

occ commented Apr 15, 2013

I believe it's fixed in the issue-41 branch (in 183ecc2). Could you take a look and let me know?
I've also updated the jsfiddle to quickly test the change - See http://jsfiddle.net/tGZGW/1/.

Thanks

@devinrhode2
Copy link

Just verified. It's good. Pretty sure there should be no merge conflicts also ;)

@niemyjski
Copy link
Collaborator

@devinrhode2,occ I'm helping maintain TraceKit upstream.. If you want to recreate this issue/pull request for issue-41 in the master (https://github.com/csnover/TraceKit) That would be greatly appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants