From 48233b601e0606b553c9cf9e863e4c11180b26ab Mon Sep 17 00:00:00 2001
From: William Braeckman <wbr@odoo.com>
Date: Thu, 9 Jan 2025 17:53:36 +0100
Subject: [PATCH] [IMP] runbot: allow changing trigger from stat page

Adds a new selection field to change trigger directly from the stat
page.
---
 runbot/controllers/frontend.py           | 18 ++++++++++++++
 runbot/static/src/stats/stats_config.js  | 31 ++++++++++++++++++++++++
 runbot/static/src/stats/stats_config.xml |  7 +++++-
 runbot/static/src/stats/stats_root.js    | 14 +++++++++++
 runbot/static/src/stats/use_config.js    | 18 ++++++++++++++
 runbot/templates/build_stats.xml         |  1 +
 6 files changed, 88 insertions(+), 1 deletion(-)

diff --git a/runbot/controllers/frontend.py b/runbot/controllers/frontend.py
index 9058a4301..a7551cf0b 100644
--- a/runbot/controllers/frontend.py
+++ b/runbot/controllers/frontend.py
@@ -3,6 +3,7 @@
 import werkzeug
 import logging
 import functools
+import itertools
 
 import werkzeug.utils
 import werkzeug.urls
@@ -620,10 +621,27 @@ def list_config_categories(config):
 
         categories = sorted(categories)
 
+        triggers = bundle.project_id.trigger_ids.filtered(
+            lambda t: t.has_stats and not t.manual
+        ).sorted(
+            lambda t: (t.category_id.id, t.sequence, t.id)
+        )
+        triggers_by_category = defaultdict(list)
+        slug = request.env['ir.http']._slug
+        for trig in triggers:
+            triggers_by_category[trig.category_id.name].append(
+                {
+                    'id': trig.id,
+                    'slug': slug(trig),
+                    'name': trig.name,
+                },
+            )
         context = {
             'stats_categories': categories,
             'bundle': bundle,
             'trigger': trigger,
+            # Category name -> List of trigger name + id
+            'triggers_by_category': triggers_by_category
         }
 
         return request.render("runbot.modules_stats", context)
diff --git a/runbot/static/src/stats/stats_config.js b/runbot/static/src/stats/stats_config.js
index a74290583..ee3dc04d9 100644
--- a/runbot/static/src/stats/stats_config.js
+++ b/runbot/static/src/stats/stats_config.js
@@ -24,6 +24,20 @@ export class StatsConfig extends Component {
             },
         },
         stats_categories: { type: Array, element: String },
+        triggers_by_category: {
+            type: Object,
+            values: {
+                type: Array,
+                element: {
+                    type: Object,
+                    shape: {
+                        id: { type: Number },
+                        slug: { type: String },
+                        name: { type: String },
+                    }
+                }
+            }
+        },
     };
 
     setup() {
@@ -43,4 +57,21 @@ export class StatsConfig extends Component {
     onClickNext() {
         this.env.bus.trigger('click-next', {});
     }
+
+    /**
+     * Called when the trigger selection is changed.
+     * This changes the config a bit and redirects the user towards the same page with the new trigger.
+     *
+     * @param {Event} event the event
+     */
+    onChangeTrigger(event) {
+        const { origin, pathname, search } = window.location;
+        const [_, bundle] = /\/runbot\/stats\/(.+)\/.+/.exec(pathname);
+        const newParams = this.config.asSearchParams();
+        this.config.getTriggerSpecificKeys().forEach(
+            (key) => newParams.delete(key)
+        );
+        console.log( `${origin}/runbot/stats/${bundle}/${event.target.value}${search}#${newParams.toString()}`);
+        window.location.href = `${origin}/runbot/stats/${bundle}/${event.target.value}${search}#${newParams.toString()}`;
+    }
 };
diff --git a/runbot/static/src/stats/stats_config.xml b/runbot/static/src/stats/stats_config.xml
index 4e8478828..cc7439595 100644
--- a/runbot/static/src/stats/stats_config.xml
+++ b/runbot/static/src/stats/stats_config.xml
@@ -4,7 +4,12 @@
     <nav class="navbar navbar-light">
       <div class="container">
         <b>Bundle:</b><t t-out="props.bundle.name"/>
-        <b>Trigger:</b><t t-out="props.trigger.name"/>
+        <b>Trigger:</b>
+        <select class="form-select text-capitalize" aria-label="Select Trigger" t-on-change="(ev) => this.onChangeTrigger(ev)">
+          <optgroup t-foreach="Object.entries(props.triggers_by_category)" t-as="entry" t-key="entry[0]" t-att-label="entry[0]">
+            <option t-foreach="entry[1]" t-as="trigger" t-key="trigger.slug" t-out="trigger.name" t-att-value="trigger.slug" t-att-selected="trigger.id === props.trigger.id ? 'selected' : undefined"/>
+          </optgroup>
+        </select>
         <b>Stat Category:</b>
         <select class="form-select text-capitalize" aria-label="Stat Category" t-model="config.key_category"> 
           <option t-foreach="props.stats_categories" t-as="category" t-key="category" t-attf-value="{{category}}">
diff --git a/runbot/static/src/stats/stats_root.js b/runbot/static/src/stats/stats_root.js
index 16484851a..35b683aa5 100644
--- a/runbot/static/src/stats/stats_root.js
+++ b/runbot/static/src/stats/stats_root.js
@@ -28,6 +28,20 @@ export class StatsRoot extends Component {
             },
         },
         stats_categories: { type: Array, element: String },
+        triggers_by_category: {
+            type: Object,
+            values: {
+                type: Array,
+                element: {
+                    type: Object,
+                    shape: {
+                        id: { type: Number },
+                        slug: { type: String },
+                        name: { type: String },
+                    }
+                }
+            }
+        },
     };
 
     setup() {
diff --git a/runbot/static/src/stats/use_config.js b/runbot/static/src/stats/use_config.js
index 47574570a..54be708c1 100644
--- a/runbot/static/src/stats/use_config.js
+++ b/runbot/static/src/stats/use_config.js
@@ -42,6 +42,15 @@ export class Config {
         return new Config(config);
     }
 
+    /**
+     * Returns the config a an URLSearchParams object.
+     *
+     * @return {URLSearchParams}
+     */
+    asSearchParams() {
+        return new URLSearchParams({...this});
+    }
+
     /**
      * Updates the url hash according to the current state of the config.
      */
@@ -70,6 +79,15 @@ export class Config {
         return ['mode', 'nb_dataset', 'display_aggregate', 'visible_keys'];
     }
 
+    /**
+     * Gets a set of keys that should not be kept when changing trigger.
+     *
+     * @returns {string[]} set of keys to remove when changing trigger.
+     */
+    getTriggerSpecificKeys() {
+        return ['center_build_id', 'key_category', 'visible_keys'];
+    }
+
     /**
      * Gets the visible keys as an array instead of string.
      *
diff --git a/runbot/templates/build_stats.xml b/runbot/templates/build_stats.xml
index a6d4ebe15..a3a784fd1 100644
--- a/runbot/templates/build_stats.xml
+++ b/runbot/templates/build_stats.xml
@@ -70,6 +70,7 @@
             'bundle': {'id': bundle.id, 'name': bundle.name},
             'trigger': {'id': trigger.id, 'name': trigger.name},
             'stats_categories': stats_categories,
+            'triggers_by_category': triggers_by_category,
           })"/>;
         </script>
         <div id="wrapwrap">This page requires javascript to load</div>