Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonsai API Client for Go #11

Merged
merged 49 commits into from
May 7, 2024
Merged

Bonsai API Client for Go #11

merged 49 commits into from
May 7, 2024

Conversation

momer
Copy link
Collaborator

@momer momer commented May 3, 2024

Spec/docs complete implementation of a Bonsai API Client in Go; comparison against live endpoints and required changes based on those responses are forthcoming in future PRs!

momer and others added 30 commits April 30, 2024 19:51
Refactoring due to aggressive linting; add golanglint-ci github action
tests to keep encapsulation and share a singular multiplexer/router
Cluster Client; update test router.
…esponse

Suppress unmarshal errors in the unexpected event that API doesn't return an error descriptor in the body
All provisioning calls are rate limited per config. Default is 5 requests/min per the docs
momer and others added 19 commits May 3, 2024 16:03
Update Authentication, fix Clusters.Update.
Add Integration tests, recordings of responses for regression testing, update client authentication, and fix Cluster.Update
…urrently support pagination, but, the comparison that they referenced was incorrect
This commit is essentially a no-op,
… headers etc.). Run the VCR suite with REC_ONLY to update
…safely

QA/Allow recording requests fixtures safely
… the license; this repo has no source/affiliation from any hashicorp repository or code.
…rom-license

Update LICENSE copyright to be correct
Add clusters demo; update imports for v1 - will need to add back in versions for versions >= 2
…g-and-security

Add TESTING.md with details on running/adding to the test suite
…ing-md

Move README#Contributing to CONTRIBUTING.md
Copy link
Member

@nz nz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've got all the basics running locally and will send up a PR of my own for a Nix-based development environment. Appreciate the very thorough docs, examples, and dev tooling in here.

@nz nz merged commit cf3dfef into main May 7, 2024
4 checks passed
@nz nz deleted the dev branch May 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants