-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bonsai API Client for Go #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…infart bug in IoClose
Feat/client tests
Refactoring due to aggressive linting; add golanglint-ci github action
Feat/spaces client
Feat/release client
tests to keep encapsulation and share a singular multiplexer/router
Cluster Client; update test router.
Chore/update test handlefuncs
…turn an error descriptor in the body
…esponse Suppress unmarshal errors in the unexpected event that API doesn't return an error descriptor in the body
…ests/min per the docs
All provisioning calls are rate limited per config. Default is 5 requests/min per the docs
Update project title in README
Patch golang/protobuf; addressing CVE-2024-24786
Add documentation details
Update Authentication, fix Clusters.Update.
Add Integration tests, recordings of responses for regression testing, update client authentication, and fix Cluster.Update
…urrently support pagination, but, the comparison that they referenced was incorrect
This commit is essentially a no-op,
… headers etc.). Run the VCR suite with REC_ONLY to update
…safely QA/Allow recording requests fixtures safely
… the license; this repo has no source/affiliation from any hashicorp repository or code.
…rom-license Update LICENSE copyright to be correct
…ersions for versions >= 2
Add clusters demo; update imports for v1 - will need to add back in versions for versions >= 2
…g-and-security Add TESTING.md with details on running/adding to the test suite
…ing-md Move README#Contributing to CONTRIBUTING.md
nz
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I've got all the basics running locally and will send up a PR of my own for a Nix-based development environment. Appreciate the very thorough docs, examples, and dev tooling in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec/docs complete implementation of a Bonsai API Client in Go; comparison against live endpoints and required changes based on those responses are forthcoming in future PRs!