-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ome_model Python package to its own repository #194
Comments
Especially if we feel comfortable that our existing scripts could be re-written on top of ome-types, I'd be 👍 trying to unify on it. |
Agreed, as a proof of concept, I worked on a minimal example upgrading a IDR script generating an HCS companion file using this package to The code difference is very reasonable - see IDR/idr0092-ostrop-organoid#2 and the generated OME-XML is consistent with the original one with the only differences being related to attribute ordering and UUIDs. Based on this minimal investigation, I am further inclined to remove this project and deprecate it in favor of |
#199 was opened to deprecate the Python code and redirect possible consumers towards using |
Hey @sbesson @joshmoore, thanks for the ping. Sure, I would happily extend the ome-types documentation. The use case of turning a regular tiff into an OME-TIFF is a common one that we definitely should have an example of. Would you have time to contribute that? (also ok if not) |
Thanks @tlambert03, I'll try and open a contribution against the docs in the upcoming days and we can discuss on the PR |
The code under https://github.com/ome/ome-model/tree/v6.3.6/ome_model has had little maintenance/development over the last 4 years.
Functionally, its content is also very different from the rest of this code base which contains:
1- the source XSD files for the OME data model
2- sample XML files for the different schema versions
3- the code-generated Java implementation of the OME model objects
Following the extraction to a separate repository, a decision should likely be made with regard to maintaining it vs archiving it in favor of other community Python projects like https://pypi.org/project/ome-types/.
Originally posted by @sbesson in #193 (review)
The text was updated successfully, but these errors were encountered: