Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review upload/download of artifacts in GHA #447

Closed
omereleases opened this issue Sep 16, 2024 · 5 comments
Closed

Review upload/download of artifacts in GHA #447

omereleases opened this issue Sep 16, 2024 · 5 comments
Assignees
@dominikl

Comments

@omereleases
Copy link

using v4 leads to error
@omereleases
Copy link
Author

v3: zip are not uploaded

@sbesson
Copy link
Member

sbesson commented Sep 16, 2024

Looking at https://github.com/ome/omero-insight/actions/runs/10884718399, looks like the workflow needs to be updated to match the breaking changes in the actions if you want to move to {upload,download}-artifact@v4. In particular artifacts are no longer mutable - see also https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

@jburel
Copy link
Member

jburel commented Sep 16, 2024

exactly
I did not have time to look at that now
@dominikl could you have a look?

@dominikl dominikl self-assigned this Sep 17, 2024
@pwalczysko pwalczysko mentioned this issue Sep 19, 2024
Merged
@pwalczysko
Copy link
Member

Possibly fixed by #448 - maybe lets wait till next release to close after this :)

@jburel
Copy link
Member

jburel commented Sep 19, 2024

I think we can close it

@jburel jburel closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikl dominikl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jburel @sbesson @pwalczysko @dominikl @omereleases