Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Logging #6

Open
bjartek opened this issue Feb 5, 2024 · 0 comments
Open

[FEATURE] Logging #6

bjartek opened this issue Feb 5, 2024 · 0 comments

Comments

@bjartek
Copy link
Collaborator

bjartek commented Feb 5, 2024

Issue to be solved

Atm flowkit uses a custom logger that includes a spinner that is deferred. This means that when using flowkit in a service it is not possible to turn on the debug/spinner log since then all output in that service is garbled by this spinner.

Suggest A Solution

Introduce a logging framework like zerolog that is used in many other apps and move the spinner code to flow-cli repo. If needed split up methods that require multipe spinner in cli, but keep the old impl as is for bc.

What are you currently working on that this is blocking?

I am investigating an corner case in flowdiver ingestion engine where crescendo is flaky but the other networks are not. The lack of good observability hurts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant