You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue proposes changes to enhance flexibility in handling PyTorch modules by allowing initialized modules to be passed to the base classes. This could help streamline workflows where pre-initialized or pre-trained models are frequently used.
Current Implementation
The current Regressor and similar classes require a module type (Type[torch.nn.Module]) to instantiate a model internally. This design works well for simple use cases but restricts flexibility when users need to use pre-initialized modules.
Discussion Points
Impact on Existing Workflows:
Will allowing initialized modules complicate initialization for existing users?
Documentation Updates:
How should we structure documentation to highlight this change?
However, with this change we would diverge from skorch.
Best
Cedric
The text was updated successfully, but these errors were encountered:
Hi @kulbachcedric,
That looks good 👍
I think it's a good idea to allow already initialized modules for. Makes it easier if you want to set some model hyperparameters before passing the module to DeepRiver.
This issue proposes changes to enhance flexibility in handling PyTorch modules by allowing initialized modules to be passed to the base classes. This could help streamline workflows where pre-initialized or pre-trained models are frequently used.
Current Implementation
The current Regressor and similar classes require a module type (Type[torch.nn.Module]) to instantiate a model internally. This design works well for simple use cases but restricts flexibility when users need to use pre-initialized modules.
Discussion Points
Impact on Existing Workflows:
Will allowing initialized modules complicate initialization for existing users?
Documentation Updates:
How should we structure documentation to highlight this change?
However, with this change we would diverge from skorch.
Best
Cedric
The text was updated successfully, but these errors were encountered: