-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix envoy access logs #1930
base: main
Are you sure you want to change the base?
Fix envoy access logs #1930
Conversation
- Remove attributes that cause problems in the Collector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these attributes are defined by the OpenTelemetry Semantic Conventions: https://github.com/open-telemetry/semantic-conventions/tree/main/model/http
Would it be feasible to fix the opensearch mappings instead?
I know that some of these are in the semantic conventions, but I believe Envoy doesn't send them correctly. I didn't find a good reference configuration and don't know a way to fix these in the Envoy configuration. We can add these attributes back when we get them working. I don't see how we could fix this with the OpenSearch mapping because the batch processor also shows the same problem. |
The error is shown in the batch processor because is the error propagated by the OpenSearch exporter, see https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/batchprocessor/batch_processor.go#L263 |
OK, I didn't realize this is only opensearch related. I wonder why the automatic mappings are not enough. |
Not sure, I am not very familiar with OpenSearch. Have you tried removing the corresponding index? (maybe the |
I ran |
Not on my environment, just tested with nightly |
Changes
Fix envoy access logs
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.