load product catalog periodically #1919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
rogercoll
reviewed
Jan 16, 2025
| @@ -26,7 +26,7 @@ | |||
| }, | |||
| { | |||
| "id": "1YMWWN1N4O", | |||
| "name": "Eclipsmart Travel Refractor Telescope", | |||
| "name": "THIS IS MY PRODUCT NAME", | |||
| ticker := time.NewTicker(time.Duration(interval) * time.Second) | ||
|
|
||
| go func() { | ||
| for { |
There was a problem hiding this comment.
It would be best to have the programs' context here so it can be properly shutdown, but it seems it would require a major refactor to the codebase (all other init functions as well). We can keep it for a future improvement.
| @@ -399,6 +399,7 @@ services: | |||
| environment: | |||
| - FLAGD_HOST | |||
| - PRODUCT_CATALOG_PORT | |||
| - PRODUCT_CATALOG_RELOAD_INTERVAL | |||
There was a problem hiding this comment.
Should we mount the products to the container?
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1892
PRODUCT_CATALOG_RELOAD_INTERVALThis allows the user to change the products without rebuilding the product-catalog service. The products can also be updated after the demo is running. The change also paves the way for reloading the product catalog on a period timer, allowing the product list to be backed by more dynamic sources such as a database.
Finally, this change will require some updates to the Helm chart to load and mount the product list via a ConfigMap.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.