Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling/Disabling Kserve breaks modelmesh reconciliation in RHODS 2.4 #122

Closed
lugi0 opened this issue Nov 13, 2023 · 3 comments
Closed
Labels
kind/bug Something isn't working

Comments

@lugi0
Copy link

lugi0 commented Nov 13, 2023

/kind bug

What steps did you take and what happened:
After Enabling/Disabling Kserve, modelmesh will be unable to reconcile through the DSC because of an error caused by the inferenceservice CRD

Component reconciliation failed:
        CustomResourceDefinition.apiextensions.k8s.io
        "inferenceservices.serving.kserve.io" is invalid:
        [spec.conversion.strategy: Required value,
        spec.conversion.webhookClientConfig: Forbidden: should not be set when
        strategy is not set to Webhook]

Deleting the MutatingWebHook does not seem to fix this, however if one manually edits the YAML of the InferenceService CRD to remove the spec.conversion block it appears to be fixed and modelmesh can then reconcile again.
However this probably breaks Kserve (if enabled/reenabled later on)

What did you expect to happen:

What's the InferenceService yaml:
[To help us debug please run kubectl get isvc $name -n $namespace -oyaml and paste the output]

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Istio Version:
  • Knative Version:
  • KServe Version:
  • Kubeflow version:
  • Open Data Hub version:
  • Deployment Environment:[cloud (aws|gcp|ibm|azure), on prem, edge ]
  • OpenShift version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@bdattoma
Copy link

related PR: #120. Unsure if that one covers the issue here.

@israel-hdez
Copy link

Closing as resolved, since I'm no longer observing this issue in 2.5.

@github-project-automation github-project-automation bot moved this from New/Backlog to Done in ODH Model Serving Planning Dec 20, 2023
@bdattoma
Copy link

Closing as resolved, since I'm no longer observing this issue in 2.5.

@israel-hdez Reconciliation seems to be fixed, however the overall issue is still present and tracked here: RHOAIENG-908

Jooho pushed a commit to Jooho/kserve that referenced this issue Feb 28, 2024
…tudio-kserve-router-28

Red Hat Konflux update kserve-router-28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants