-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass AWS credentials correctly #168
fix: pass AWS credentials correctly #168
Conversation
Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @openedx/2u-arch-bom! This is ready for review. Thanks! |
Looks about right. :-) Could you bump the version in |
0145a04
to
c05d43a
Compare
c05d43a
to
5a7f5ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
v3.4.1 is released |
Description
Fixes passing of AWS credentials, which are currently passed in inverse order.
Supporting information
https://discuss.openedx.org/t/bug-report-openedx-django-pyfs-uses-s3-access-key-id-and-secret-in-place-of-each-other/11874
Testing instructions
Deadline
None