feat: major version upgrades for frontend-platform & frontend-build #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sorry this has been sitting unreviewed for so long! I would love to see this merged!
I left a couple suggestions to switch to ^ for dependency pinning instead of using exact versions.
If you could rebase this to resolve the merge conflicts I'll gladly push to get this merged!
Thanks so much for this PR!
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", | |||
| "@edx/frontend-platform": "7.1.3", | |||
| "@edx/frontend-platform": "8.0.0", | |||
There was a problem hiding this comment.
Suggested change
| "@edx/frontend-platform": "8.0.0", | |
| "@edx/frontend-platform": "^8.0.0", |
package.json
Outdated
| @@ -73,7 +73,7 @@ | |||
| "devDependencies": { | |||
| "@edx/browserslist-config": "^1.1.1", | |||
| "@edx/reactifex": "1.1.0", | |||
| "@openedx/frontend-build": "13.1.4", | |||
| "@openedx/frontend-build": "14.0.3", | |||
There was a problem hiding this comment.
Suggested change
| "@openedx/frontend-build": "14.0.3", | |
| "@openedx/frontend-build": "^14.0.3", |
…ilalqamar95/platform-build-major-upgrades
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 124 124
Lines 2299 2299
Branches 646 645 -1
=======================================
Hits 2016 2016
Misses 274 274
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
@brian-smith-tcril I have updated the versions with caret & resolved the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
frontend-buildtov14&frontend-platformtov8snapshotsfor failing tests