build: Update codecov and use token #1257
Conversation
Update codecov to the latest version and start using the org-wide token for uploads. See openedx/wg-frontend#179
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1257 +/- ##
==========================================
- Coverage 87.71% 87.69% -0.03%
==========================================
Files 124 124
Lines 2288 2299 +11
Branches 636 646 +10
==========================================
+ Hits 2007 2016 +9
- Misses 272 274 +2
Partials 9 9 ☔ View full report in Codecov by Sentry. |
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| fail_ci_if_error: true |
There was a problem hiding this comment.
fail_ci_if_error is set to false in frontend-app-account (and unchanged by openedx/frontend-app-account#1063)
Just curious as to the reasoning behind explicitly setting it to true here.
There was a problem hiding this comment.
The main motivation here is to follow the pattern given by https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov. As to why the pattern is that way, I didn't write that page but I agree it makes sense to fail CI if coverage is not up to par, by default, so that at least the question is raised for every PR. Exceptions can always be made when necessary.
I did not change the ones that were set to false explicitly, assuming there was a reason they were set like that. We can always tackle that question separately. (I would definitely like to understand when not to fail CI.)
Update codecov to the latest version and start using the org-wide token for uploads.
See openedx/wg-frontend#179