Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: plugins folder not included in extract_translations #1588

Open
igobranco opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1589
Open

Translation: plugins folder not included in extract_translations #1588

igobranco opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1589

Comments

@igobranco
Copy link

The extract translations from the source code to be sent to Transifex for translations isn't including the plugins source code folder.
From my calculations, 145 strings aren't being sent to Transifex for translate because of this problem.

The extract translation uses the frontend-build:

"i18n_extract": "fedx-scripts formatjs extract",

The frontend-build only includes the src folder to extract translations:
https://github.com/openedx/frontend-build/blob/c70ef4e0a5e8702f7144f36b1b23195b94f5e09a/bin/fedx-scripts.js#L73-L76

IMO: If the plugins folder is only specific to this repository, this fix should be made on this repo, if the plugins usage is a patter that is going to be replicated to other repositories, then the extract could be fixed on the openedx/frontend-build repo.

igobranco added a commit to fccn/frontend-app-authoring that referenced this issue Jan 14, 2025
@igobranco igobranco linked a pull request Jan 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant