You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Double clicking activates selection and maintains focus, except on collections, which are now opened on double click
I also think double click should open the editor modal for XBlocks as well
Implementation details
In this context, "double clicking" a component card is actually two separate single clicks:
First click on the card selects the component, and puts its info into the sidebar.
Second click on the card should open the editor modal.
With #1575, we added sidebar actions to the query string, e.g ?sa=manage-team causes the "Library Team" modal to be opened, and that sa state variable actually controls whether the modal is open or closed.
This implementation should continue this approach by adding another SidebarAction that controls whether the "edit modal" is open or closed for the currently selected component.
Would also be a good idea to refactor the componentBeingEdited / openComponentEditor / openComponentEditor states currently handled by the LibraryContext to make them handled by the new action state in the SidebarContext instead. The other ways of accessing the edit modal must be maintained as well, including the "edit" button on the component sidebar, and the "edit" item on the component card's menu.
The text was updated successfully, but these errors were encountered:
cf @sdaitzman 's Slack post:
Implementation details
In this context, "double clicking" a component card is actually two separate single clicks:
With #1575, we added sidebar actions to the query string, e.g
?sa=manage-team
causes the "Library Team" modal to be opened, and thatsa
state variable actually controls whether the modal is open or closed.This implementation should continue this approach by adding another SidebarAction that controls whether the "edit modal" is open or closed for the currently selected component.
Would also be a good idea to refactor the
componentBeingEdited
/openComponentEditor
/openComponentEditor
states currently handled by theLibraryContext
to make them handled by the new action state in theSidebarContext
instead. The other ways of accessing the edit modal must be maintained as well, including the "edit" button on the component sidebar, and the "edit" item on the component card's menu.The text was updated successfully, but these errors were encountered: