Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: RecommendationsPanel #410

Closed
1 task
MaxFrank13 opened this issue Aug 8, 2024 · 1 comment
Closed
1 task

[DEPR]: RecommendationsPanel #410

MaxFrank13 opened this issue Aug 8, 2024 · 1 comment
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@MaxFrank13
Copy link
Member

MaxFrank13 commented Aug 8, 2024

Proposal Date

2024-08-08

Target Ticket Acceptance Date

2024-08-22

Earliest Open edX Named Release Without This Functionality

Sumac - 2024-10

Rationale

The RecommendationsPanel was created as part of a 2U/edX initiative and I don't believe it has been used by the community. The creators of the component have successfully replaced it using the frontend-plugin-framework. If the code is indeed unused, it only serves as a liability to the community and should be removed.

Removal

This is a proposal to remove the entire RecommendationsPanel directory and its sub-components, located at src/widgets/RecommendationsPanel. This will require some refactoring around the RecommendationsPanel. For example, the LookingForChallengeWidget uses a utility function from this directory. But otherwise, this component is almost entirely decoupled from the rest of the Learner Dashboard application. Removing it shouldn't have any effect on the rest of the app configuration or view layout, as the RecommenationsPanel is not rendered by default. It is intended to be used with the WidgetSidebar PluginSlot.

Replacement

There is no intended replacement as this is presumably unused code.

Deprecation

No response

Migration

No response

Additional Info

@MaxFrank13
Discourse thread

Task List

  • Remove RecommendationsPanel directory
@MaxFrank13 MaxFrank13 self-assigned this Aug 8, 2024
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Aug 8, 2024
@MaxFrank13 MaxFrank13 moved this from Proposed to Communicated in DEPR: Deprecation & Removal Aug 8, 2024
@MaxFrank13 MaxFrank13 moved this to In Progress in Aperture-Maintained Aug 19, 2024
@MaxFrank13 MaxFrank13 moved this from Communicated to Accepted in DEPR: Deprecation & Removal Aug 27, 2024
@MaxFrank13 MaxFrank13 moved this from Accepted to Removing in DEPR: Deprecation & Removal Aug 28, 2024
@MaxFrank13 MaxFrank13 moved this from Removing to Removed in DEPR: Deprecation & Removal Aug 28, 2024
@MaxFrank13
Copy link
Member Author

Removed as of 08-28

@github-project-automation github-project-automation bot moved this from In Progress to Done in Aperture-Maintained Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Done
Status: Removed
Development

No branches or pull requests

1 participant