Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits mismatch incorrect error logged #238

Closed
renatav opened this issue Apr 27, 2022 · 1 comment
Closed

Commits mismatch incorrect error logged #238

renatav opened this issue Apr 27, 2022 · 1 comment
Assignees
Labels
bug Something isn't working security

Comments

@renatav
Copy link
Collaborator

renatav commented Apr 27, 2022

This line contains an error:

additional_commits = new_commits[len(target_commits) :]

This assumes that target repo's commits and commits read from the auth repo have the first commit in common and that target repo's commits just contain additional ones. That is not the case if auth repo was pulled manually and target repo was not

@renatav renatav added bug Something isn't working security labels Apr 27, 2022
@renatav renatav self-assigned this Oct 17, 2023
@renatav
Copy link
Collaborator Author

renatav commented Jan 11, 2024

This was reworked as a part of #374
Based on states of repositories, it is determined where the update should start from. So such mismatches should not longer be an issue

@renatav renatav closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

No branches or pull requests

1 participant