Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems impossible to specify a tag #964

Closed
kelson42 opened this issue May 12, 2024 · 5 comments
Closed

Seems impossible to specify a tag #964

kelson42 opened this issue May 12, 2024 · 5 comments
Labels

Comments

@kelson42
Copy link
Contributor

See https://farm.openzim.org/pipeline/6b73b999-8fda-4a77-b7ef-3c7a9ed93a80/debug

@kelson42 kelson42 added the bug label May 12, 2024
@benoit74
Copy link
Collaborator

This is a Zimfarm configuration issue.

Proper CLI flag is --tag and not --tags. Passing multiple tags require that the --tag flag is called multiple times like sotoki --tag "Quality Assurance" --tag "Another TAG" and this is currently not supported by the Zimfarm. I will adjust Zimfarm configuration to at least support one additional tag.

Nevertheless, I expect that we want / need to support multiple tags. Do we want to fix this in sotoki (move from --tag to --tags and process this as a CSV, this is easy but a breaking change) or in Zimfarm (add support for list flags, this most probably needs UI adaptations and will most probably come with its own share of subtle bugs). WDYT?

@kelson42
Copy link
Contributor Author

kelson42 commented May 13, 2024

Nevertheless, I expect that we want / need to support multiple tags.

Definitely, and it should be able to provide everything with a string, using ; for example as separator. This is something we have done in a few other scrapers AFAIK. CSV is uselessly too cumbersome to prepare.

@benoit74
Copy link
Collaborator

Yep, this is what I meant. Issue is here: openzim/sotoki#315

@benoit74
Copy link
Collaborator

Zimfarm + recipe reconfigured, we can now specify 1 single tag.

Task: https://farm.openzim.org/pipeline/d3e4cbf0-50a5-4385-a6ac-7167b3307ec8

The task failed due to another bug most probably linked to known problems with SE data dump

This issue is hence fixed and other issues are opened, let's close this.

@benoit74 benoit74 transferred this issue from openzim/sotoki May 13, 2024
@benoit74
Copy link
Collaborator

Btw, I transfer this issue to zimfarm repo since it is a zimfarm issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants