Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show API error messages in Preview Modal #103

Open
SiriChandanaGarimella opened this issue Nov 13, 2024 · 3 comments
Open

Show API error messages in Preview Modal #103

SiriChandanaGarimella opened this issue Nov 13, 2024 · 3 comments
Assignees

Comments

@SiriChandanaGarimella
Copy link
Collaborator

SiriChandanaGarimella commented Nov 13, 2024

Is your feature request related to a problem? Please describe.
Currently, the preview data is shown in a modal, but it doesn't display the error message returned by the API in case of failure, and also, the modal doesn't close on pressing the Escape key

Describe the solution you'd like
Let users press Escape to close the preview modal window. In case of failure, display the error message returned by the API.

Acceptance criteria

  • Modal opens immediately when "Preview Output" is clicked
  • The close button 'X' appears in the top-right corner and 'close' appears in the bottom-right corner
  • Modal closes when clicking X or pressing the Escape key
  • Preview content is scrollable for longer outputs
  • Modal appears centered on the screen
  • Background dims when the modal is open and disable clicks outside the modal
  • In case of failure, display an error message returned by the API
@Navreet20
Copy link

Hi,
I’d like to work on this issue as it is part of my assignment, and I’ve already started working on a solution. Could you please assign it to me?

@SiriChandanaGarimella
Copy link
Collaborator Author

@M-Ravali - Could you please confirm if you're working on this issue?

@SiriChandanaGarimella SiriChandanaGarimella changed the title Show the preview output in a modal Show API error messages in Preview Modal Dec 16, 2024
@SiriChandanaGarimella
Copy link
Collaborator Author

Updating description since part of this issue was already fixed in PR #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants