From 9dc49a2accdf6f62c5c5c987966f862ba4c12709 Mon Sep 17 00:00:00 2001 From: joragua Date: Thu, 23 Jan 2025 09:30:44 +0100 Subject: [PATCH] refactor: removed not implemented declarations (TODO functions) --- .../presentation/files/details/FileDetailsFragment.kt | 8 ++++---- .../presentation/files/filelist/MainFileListViewModel.kt | 3 ++- .../owncloud/android/ui/activity/FileDisplayActivity.kt | 4 ++-- .../datasources/implementation/OCLocalFileDataSource.kt | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/owncloudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt b/owncloudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt index b5ca2e500b5..17131a69291 100644 --- a/owncloudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt +++ b/owncloudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt @@ -585,11 +585,11 @@ class FileDetailsFragment : FileFragment() { } override fun updateViewForSyncInProgress() { - TODO("Not yet implemented") + // Not yet implemented } override fun updateViewForSyncOff() { - TODO("Not yet implemented") + // Not yet implemented } override fun onFileMetadataChanged(updatedFile: OCFile?) { @@ -597,11 +597,11 @@ class FileDetailsFragment : FileFragment() { } override fun onFileMetadataChanged() { - TODO("Not yet implemented") + // Not yet implemented } override fun onFileContentChanged() { - TODO("Not yet implemented") + // Not yet implemented } companion object { diff --git a/owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListViewModel.kt b/owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListViewModel.kt index c2dcb0924b3..88d24cdb360 100644 --- a/owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListViewModel.kt +++ b/owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListViewModel.kt @@ -67,6 +67,7 @@ import kotlinx.coroutines.flow.StateFlow import kotlinx.coroutines.flow.combine import kotlinx.coroutines.flow.firstOrNull import kotlinx.coroutines.flow.flatMapLatest +import kotlinx.coroutines.flow.flow import kotlinx.coroutines.flow.map import kotlinx.coroutines.flow.stateIn import kotlinx.coroutines.flow.update @@ -368,7 +369,7 @@ class MainFileListViewModel( FileListOption.ALL_FILES -> retrieveFlowForAllFiles(currentFolderDisplayed, currentFolderDisplayed.owner) FileListOption.SHARED_BY_LINK -> retrieveFlowForShareByLink(currentFolderDisplayed, currentFolderDisplayed.owner) FileListOption.AV_OFFLINE -> retrieveFlowForAvailableOffline(currentFolderDisplayed, currentFolderDisplayed.owner) - FileListOption.SPACES_LIST -> TODO() + FileListOption.SPACES_LIST -> flow {} }.toFileListUiState( currentFolderDisplayed, fileListOption, diff --git a/owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt b/owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt index ff97ffe1cf9..58a76883bf5 100644 --- a/owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt +++ b/owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt @@ -1351,8 +1351,8 @@ class FileDisplayActivity : FileActivity(), } is SynchronizeFileUseCase.SyncType.UploadEnqueued -> showSnackMessage(getString(R.string.upload_enqueued_msg)) - - null -> TODO() + null -> { // Nothing to do + } } } diff --git a/owncloudData/src/main/java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSource.kt b/owncloudData/src/main/java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSource.kt index 0bfd831c9ae..cd67af46e56 100644 --- a/owncloudData/src/main/java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSource.kt +++ b/owncloudData/src/main/java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSource.kt @@ -209,7 +209,7 @@ class OCLocalFileDataSource( } override fun saveUploadWorkerUuid(fileId: Long, workerUuid: UUID) { - TODO("Not yet implemented") + // Not yet implemented } override fun saveDownloadWorkerUuid(fileId: Long, workerUuid: UUID) {