Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging out of oC web does not log out of oC classic #5886

Closed
Deaddy opened this issue Oct 7, 2021 · 3 comments · Fixed by #6939 or #7128
Closed

Logging out of oC web does not log out of oC classic #5886

Deaddy opened this issue Oct 7, 2021 · 3 comments · Fixed by #6939 or #7128
Assignees
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@Deaddy
Copy link

Deaddy commented Oct 7, 2021

This might be just an annoyance, internally we are also still unsure whether we see this as a huge problem or if it is just a meh issue for power users during the transition away from oC classic.

Steps to reproduce

  1. Run ownCloud web as app for owncloud classic
  2. Log into ownCloud web via the menu in the upper left corner
  3. Authenticate the app
  4. Log out of owncloud web
  5. Be still logged in classic owncloud

Expected behaviour from a technical perspective

Everything works as expected. We have authorized a app, which should be independent of being logged into the classical webinterface or not.
You are being redirected to the authorization page for the webapp, where you can just click again re-authorize.

Expected behaviour from a user or admin perspective

To be logged out in the classic webinterface as well, I suspect. And maybe not being able to authorize without

Actual behaviour

See expected behaviour from a technical perspective. ;-)

relevant parts of the current setup

owncloud 10.8 with 4.2.0 web app
skipping all the other stuff because as it is not really relevant to the discussion

Possible solutions and discussion

I think before we look at a technical solution the question is whether or not this much of an issue.

  • somehow hack around so that logging out the web app also logs out the classic interface
  • (attempting to) redirect to the original webinterface where you are possibly still logged in after logout
  • accept this behaviour and move on, find a clearer way to communicate to the user
  • ???
@kulmann
Copy link
Contributor

kulmann commented Oct 12, 2021

Regarding UX this gets even worse with a trusted oauth2 client - then the authorize screen doesn't exist and you are immediately redirected into ownCloud Web again. Essentially, logging out in ownCloud Web has no effect at all then.

@kulmann kulmann added Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working labels Dec 8, 2021
@kulmann kulmann added Priority:p1-urgent Consider a hotfix release with only that fix and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Dec 13, 2021
@tbsbdr
Copy link

tbsbdr commented Dec 22, 2021

@kulmann in some usecases this is a severe bug if the logout is done for security reasons. though there is a workaround (switch to oc10 and logout here), the workaround might not be obvious to every user. imo this p1 bug should be amongst top 3 in the queue ;-) would you agree?

@kulmann
Copy link
Contributor

kulmann commented May 20, 2022

Apparently the backend session handling is really broken for the combination of oauth2 and classic login. There is #7018 as the other facet of the "client logout issue" (logout in classic doesn't logout in web).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
No open projects
Status: Done
4 participants