From aa72a203bafb5a4bffecb01d99e979b5b52896d9 Mon Sep 17 00:00:00 2001 From: Matej Focko Date: Mon, 21 Oct 2024 15:44:21 +0200 Subject: [PATCH] !!!!docs(events): add question for review remove after resolving Signed-off-by: Matej Focko --- packit_service/worker/events/event.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packit_service/worker/events/event.py b/packit_service/worker/events/event.py index 5a00ff2d0..9ccddf01c 100644 --- a/packit_service/worker/events/event.py +++ b/packit_service/worker/events/event.py @@ -418,6 +418,7 @@ def get_db_project_object(self) -> Optional[AbstractProjectObjectDbType]: def get_db_project_event(self) -> Optional[ProjectEventModel]: return None + # [XXX] Cache me up inside, related to the comment right above. @property def db_project_object(self) -> Optional[AbstractProjectObjectDbType]: if not self._db_project_object: @@ -500,6 +501,8 @@ def pre_check(self) -> bool: @abstractmethod def get_packages_config(self): ... + # [XXX] This seems to be used only by .project property, and also + # in a caching way… not sure why do we need two doing the same thing… @abstractmethod def get_project(self) -> GitProject: ...