"Approval" section in docs not applicable for Gitlab upstreams

[jrybar-rh]

The section 2. Approval in Packit Onboarding Guide only works for Github upstreams.
Gitlab users need to be approved manually every time.

[TomasTomecek]

This is correct, I had to manually approve the namespace - the automated approval workflow is not triggered on GitLab right now.

[lachmanfrantisek]

Slightly related to #1708.

What needs to be done on our side:

• create a new notifications repository on each forge we want to support
• make Packit create a new issue in that repository if a user is not allowed and the issue does not exist. (Currently, the issue is created only after the GitHub app installation.)
• update the code to accept a list of projects, not a single one (ideally, make it configurable):

  • packit-service/packit_service/worker/handlers/forges.py

    Lines 123 to 124 in da94cc9

    	@reacts_to(event=IssueCommentEvent)
    	class GithubFasVerificationHandler(JobHandler):

  • packit-service/packit_service/worker/handlers/forges.py

    Lines 148 to 159 in da94cc9

    	def pre_check(self) -> bool:
    	"""
    	Checks whether the Packit verification command is placed in
    	packit/notifications repository in the issue our service created.
    	"""
    	if not (
    	self.project.namespace == "packit" and self.project.repo == "notifications"
    	):
    	logger.debug(
    	"Packit verification comment command not placed in packit/notifications repository."
    	)
    	return False

  • (Looking at the code, any forge.dot.something/packit/notifications should work now already..;)
• update docs

[TomasTomecek]

We need to scope this properly as there are many paths to take.

[lachmanfrantisek]

To make it clear: ideally, we will get rid of the per-installation requirements and do a per-job check (so e.g., we will not require FAS for some types of jobs).

As a result of that work, we don't need to support GitLab in the approval process (this issue) because it will not be needed at all.

[lachmanfrantisek]

@jrybar-rh Hello, this issue (and #1708 as well) will not be needed once we finish our #1850 epic.

With that, I am closing this. Feel free to watch the epic and/or we can discuss it at the weekly sync meeting.