Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case of multiple Version tags, Specfile.update_version() always updates the first one #327

Closed
nforro opened this issue Nov 28, 2023 · 0 comments · Fixed by #328
Closed

In case of multiple Version tags, Specfile.update_version() always updates the first one #327

nforro opened this issue Nov 28, 2023 · 0 comments · Fixed by #328
Assignees
@nforro
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@nforro
Copy link
Member

nforro commented Nov 28, 2023

There can be multiple Version tags in a spec file, in different condition branches.
Specfile.update_version() always updates the first one.
Example of such a spec file: https://src.fedoraproject.org/rpms/python-mne/blob/rawhide/f/python-mne.spec
@nforro nforro self-assigned this Nov 28, 2023
@nforro nforro added the kind/bug Something isn't working. label Nov 28, 2023
@nforro nforro added gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. complexity/single-task Regular task, should be done within days. area/general Related to whole service, not a specific part/integration. labels Nov 28, 2023
@nforro nforro mentioned this issue Nov 29, 2023
Merged
@nforro nforro moved this from new to in-review in Packit Kanban Board Nov 29, 2023
softwarefactory-project-zuul bot added a commit that referenced this issue Dec 1, 2023
@softwarefactory-project-zuul
Take validity into account when accessing tags and macro definitions …
152f67c 
…by name (#328)

Take validity into account when accessing tags and macro definitions by name

Fixes #327.
RELEASE NOTES BEGIN
When accessing tags or macro definitions by name, specfile now takes validity into account when looking for the best match. For example if there are two instances of Version tag, one in the true and one in the false branch of a condition, Specfile.version will always access the one that is in the true branch.
RELEASE NOTES END

Reviewed-by: Maja Massarini
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nforro nforro

Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take validity into account when accessing tags and macro definitions by name packit/specfile
1 participant
@nforro