Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow username and password authentication #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow username and password authentication #8

wants to merge 1 commit into from

Conversation

spoukke
Copy link
Contributor

@spoukke spoukke commented Oct 15, 2021

No description provided.

@spoukke spoukke requested a review from busser November 8, 2021 08:22
busser
busser reviewed Nov 8, 2021
View reviewed changes
main.go
if err := checkoutGitRepository(sshPrivateKey, workingDir, repositoryURL, gitBranch); err != nil {
auth, err := setAuth(username, password, sshPrivateKey)
if err != nil {
log.Fatalf("failed to set authentication with username %q, password %q, sshPrivateKey %q: %w", username, password, sshPrivateKey, err)
Copy link
Contributor

@busser busser Nov 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not log the private key.

busser
busser reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@busser busser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First priority: confirm that it works.
Then: refactor to handle different options cleanly.

@spoukke spoukke linked an issue Dec 13, 2021 that may be closed by this pull request
Enable username/password authentication #1
Open
@spoukke spoukke marked this pull request as ready for review December 13, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busser busser busser left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable username/password authentication
2 participants
@spoukke @busser