From b314def91dfbfad9ba64663e4922c21bd77da6a9 Mon Sep 17 00:00:00 2001 From: Luca Cavallaro Date: Wed, 24 Jul 2024 17:33:39 +0200 Subject: [PATCH] Remove networking variables from azure_app_service_exposed module (#66) --- infra/modules/azure_app_service_exposed/app_service.tf | 2 -- .../modules/azure_app_service_exposed/app_service_slot.tf | 2 -- infra/modules/azure_app_service_exposed/variables.tf | 8 -------- 3 files changed, 12 deletions(-) diff --git a/infra/modules/azure_app_service_exposed/app_service.tf b/infra/modules/azure_app_service_exposed/app_service.tf index 5bd6445bc..75e8cdedf 100644 --- a/infra/modules/azure_app_service_exposed/app_service.tf +++ b/infra/modules/azure_app_service_exposed/app_service.tf @@ -7,7 +7,6 @@ resource "azurerm_linux_web_app" "this" { https_only = true public_network_access_enabled = true - virtual_network_subnet_id = var.azurerm_subnet_id identity { type = "SystemAssigned" @@ -19,7 +18,6 @@ resource "azurerm_linux_web_app" "this" { vnet_route_all_enabled = true health_check_path = var.health_check_path health_check_eviction_time_in_min = 2 - ip_restriction_default_action = "Deny" application_stack { node_version = var.stack == "node" ? "${var.node_version}-lts" : null diff --git a/infra/modules/azure_app_service_exposed/app_service_slot.tf b/infra/modules/azure_app_service_exposed/app_service_slot.tf index b686672c9..7e38a1cde 100644 --- a/infra/modules/azure_app_service_exposed/app_service_slot.tf +++ b/infra/modules/azure_app_service_exposed/app_service_slot.tf @@ -7,7 +7,6 @@ resource "azurerm_linux_web_app_slot" "this" { https_only = true public_network_access_enabled = true - virtual_network_subnet_id = var.azurerm_subnet_id identity { type = "SystemAssigned" @@ -19,7 +18,6 @@ resource "azurerm_linux_web_app_slot" "this" { vnet_route_all_enabled = true health_check_path = var.health_check_path health_check_eviction_time_in_min = 2 - ip_restriction_default_action = "Deny" application_stack { node_version = var.stack == "node" ? "${var.node_version}-lts" : null diff --git a/infra/modules/azure_app_service_exposed/variables.tf b/infra/modules/azure_app_service_exposed/variables.tf index 0e1a77938..22affaef3 100644 --- a/infra/modules/azure_app_service_exposed/variables.tf +++ b/infra/modules/azure_app_service_exposed/variables.tf @@ -97,11 +97,3 @@ variable "sticky_app_setting_names" { description = "(Optional) A list of application setting names that are not swapped between slots" default = [] } - -# ------------ NETWORKING ------------ # - -variable "azurerm_subnet_id" { - type = string - description = "(Optional) Id of the subnet the Function App uses for outbound connectivity" - default = null -} \ No newline at end of file