Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [EUDIW-212] Improve routes and screens naming #51

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Jan 2, 2025

Short description

This PR improves routes and screens naming across the app for better clarity and to avoid wrong imports.

List of changes proposed in this pull request

  • Add prefix for each screen and route of the pid issuance flow to avoid confusing them with the ones for a generic credential implemented in feat: [EUDIW-206] Add generic credential issuance #50;
  • Add NAV suffix to screens which contain a navigator to better differentiate them.
  • Change the route name for the main navigation which was wrongly referring to the tab navigator.

How to test

Static checks should be enough but check if there's any regression in the pid issuance flow.

@LazyAfternoons LazyAfternoons changed the title refactor[EUDIW-212]: Improve routes and screens name refactor[EUDIW-212]: Improve routes and screens naming Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue EUDIW-212

@LazyAfternoons LazyAfternoons marked this pull request as ready for review January 2, 2025 14:26
@LazyAfternoons LazyAfternoons changed the title refactor[EUDIW-212]: Improve routes and screens naming refactor [EUDIW-212]: Improve routes and screens naming Jan 3, 2025
@LazyAfternoons LazyAfternoons changed the title refactor [EUDIW-212]: Improve routes and screens naming refactor: [EUDIW-212] Improve routes and screens naming Jan 3, 2025
@LazyAfternoons LazyAfternoons merged commit 6df6257 into main Jan 13, 2025
3 checks passed
@LazyAfternoons LazyAfternoons deleted the EUDIW0-212-refactor-routes-screens-name branch January 13, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants