[FRAME] Warn when using default SubstrateWeights in production

[ggwpez]

We can probably come up with a cfg clause to add a deprecation to the auto-generated SubstrateWeights to prevent them from accidentally being used in production.
Either by using production profile, on-chain-release-build, std or similar.

Idea came up here.

[Krayt78]

Hi @ggwpez I would love to be assigned to this task :)

[ggwpez]

Sounds good (if you are still interested). Sorry i was out of office last month.
This issue just came up and should also be easy to do: #7038

[Krayt78]

Sounds good (if you are still interested). Sorry i was out of office last month. This issue just came up and should also be easy to do: #7038

Thx !
Should this be done with specific flags or only std (or is it no_std like Kian suggested before ?)?

[ggwpez]

I think maybe starting with a deprecated warning that is triggered on #[cfg(not(feature = "std"))] would be the easiest. Our kitchensink and testing runtimes could then get an allow(deprecated) on the configuration.

Not sure if it will all work out, but maybe just playing around with it a bit will show how we can solve it. One thing is certain though: We never enable std when building our production runtimes.

[Krayt78]

I think maybe starting with a deprecated warning that is triggered on #[cfg(not(feature = "std"))] would be the easiest. Our kitchensink and testing runtimes could then get an allow(deprecated) on the configuration.

Not sure if it will all work out, but maybe just playing around with it a bit will show how we can solve it. One thing is certain though: We never enable std when building our production runtimes.

Roger the warning was added to this PR #7046. Maybe later on we might have an actual "production" flag used everywhere that could replace this, but i guess that would require a lot of small code changes everywhere

[bkchr]

I think maybe starting with a deprecated warning that is triggered on #[cfg(not(feature = "std"))] would be the easiest. Our kitchensink and testing runtimes could then get an allow(deprecated) on the configuration.

Warnings from the wasm build process are not propagated to the main build. (If you not enable WASM_BUILD_RUSTFLAGS=warnwhateveritiscalled)