Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codec, scale-info and log from umbrella crate. #6976

Open
aurexav opened this issue Dec 21, 2024 · 1 comment
Open

Use codec, scale-info and log from umbrella crate. #6976

aurexav opened this issue Dec 21, 2024 · 1 comment

Comments

@aurexav
Copy link
Contributor

aurexav commented Dec 21, 2024

          > Why do we have to import `codec`, `scale-info` & `log` every-time even when it is in the umbrella crate?

Because they hardcoded some of those things in the frame-support's macros. Suggest changing those marcos usage to frame::codec instead of ::crate::codec/crate::codec.

Originally posted by @AurevoirXavier in #6504 (comment)

@bkchr
Copy link
Member

bkchr commented Dec 22, 2024

codec and scale-info will not work that easily. These macros need to know the path to the crate and if the crate is not part of the Cargo.toml, they will not find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants