Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-bot for the people! #7049

Closed
bkchr opened this issue Jan 6, 2025 · 0 comments · Fixed by #7231
Closed

cmd-bot for the people! #7049

bkchr opened this issue Jan 6, 2025 · 0 comments · Fixed by #7231
Assignees

Comments

@bkchr
Copy link
Member

bkchr commented Jan 6, 2025

Enable cmd-bot for all everyone and not just Parity people. Before we should check all the supported commands and if there is anything problematic, but most of the commands like prdoc or rustfmt should be fine.

github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2025
Aims to 
- close #7049 
- close paritytech/opstooling#449
- close paritytech/opstooling#463

What's changed:
- removed is paritytech member check as required prerequisite to run a
command
- run the cmd.py script taking it from master, if someone who run this
is not a member of paritytech, and from current branch, if is a member.
That keeps the developer experience & easy testing if paritytech members
are contributing to cmd.py
- isolate the cmd job from being able to access GH App token or PR
token- currently the fmt/bench/prdoc are being run with limited
permissions scope, just to generate output, which then is uploaded to
artifacts, and then the other job which doesn't run any files from repo,
does a commit/push more securely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants