Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined global variables evaluate to MISSING instead of giving an error. #440

Open
dlurton opened this issue Nov 28, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working type system Concerns data types and/or operation/function definitions

Comments

@dlurton
Copy link
Member

dlurton commented Nov 28, 2023

I don't think this is a strict vs permissive mode thing at all: I think this should probably be an error regardless of typing mode.

Repro case, paste this in side of a #[cfg(test)] in partiql-logical-planner/src/lib.rs:

    #[test]
    pub fn test_foo() {
        let out = evaluate_query("undefined_global_variable");
        println!("{:?}", &out);
    }
@jpschorr jpschorr self-assigned this Jan 8, 2024
@jpschorr jpschorr added bug Something isn't working type system Concerns data types and/or operation/function definitions labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type system Concerns data types and/or operation/function definitions
Projects
None yet
Development

No branches or pull requests

2 participants