Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for validation icons? #29

Open
danielbsig opened this issue Dec 30, 2014 · 4 comments
Open

Support for validation icons? #29

danielbsig opened this issue Dec 30, 2014 · 4 comments

Comments

@danielbsig
Copy link

Hi,

It would be very nice if this directive would support toggling the bootstrap icons as shown here: http://getbootstrap.com/css/#forms-control-validation ("With optional icons"). I'm still not 100% sure how to do this, but I guess that one way would be to check for the presence of a < i > tag, perhaps with a special CSS class attached to it, and then toggle the icons in it at the same time as the has-success and has-errors classes are turned on/off.

This could either be done automatically (detecting the presence of said < i > element), or configurable similar to the showSuccess option.

@danielbsig
Copy link
Author

... or actually a span element, which is used in the example on the bootstrap page...

@staslev
Copy link

staslev commented Jan 10, 2015

+1, validation feedback icons would make a great addition.

@jack-kerouac
Copy link

+1

@StrangelyTyped
Copy link

+1, Would settle for an option to apply .has-feedback when either has-error/has-success are added to the target element though.

The actual showing/hiding of the icons can be done relatively simply via CSS, but either you/the user needs to implement logic to govern has-feedback as well or live with has-feedback permanently applied which leaves a large padding on the right of the input field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants