Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues for ldd-cassini are not like those for other LDDs #312

Closed
matthewtiscareno opened this issue Dec 12, 2024 · 7 comments
Closed

Issues for ldd-cassini are not like those for other LDDs #312

matthewtiscareno opened this issue Dec 12, 2024 · 7 comments
Assignees
Labels
bug Something isn't working ldd-cassini Issue for ldd-cassini repository

Comments

@matthewtiscareno
Copy link

Hey @jordanpadams, why am I able to create an issue in this repo? For other LDDs, there isn't even an Issues tab, and instead issues are created at the PDS4-LDD-Issue-Repo where there are a bunch of tags to indicate the LDD to which the issue applies. However, at that location, there is no tag for ldd-cassini. Is this something to fix?

@matthewtiscareno matthewtiscareno added the bug Something isn't working label Dec 12, 2024
@jordanpadams
Copy link
Contributor

@matthewtiscareno when we first set this up, we were told that missions need their autonomy and they should not be treated the same as Discipline LDDs. That is how we treated them.

We can create generic issue templates to apply to all the mission LDD repos, but they will not include the tags. Will that work here?

@matthewtiscareno
Copy link
Author

Interesting. Some missions (such as ldd-vgr) are treated like the Discipline LDDs, and that was the only one I checked.

Maybe it's fine this way. I'm not the steward of this LDD anyway.

@jordanpadams
Copy link
Contributor

@matthewtiscareno Sorry, I am very wrong. I guess this LDD was either created before the process we instantiated or it was created incorrectly. Will update now.

@jordanpadams jordanpadams transferred this issue from pds-data-dictionaries/ldd-cassini Dec 13, 2024
@jordanpadams jordanpadams added the ldd-cassini Issue for ldd-cassini repository label Dec 13, 2024
@jordanpadams
Copy link
Contributor

jordanpadams commented Dec 13, 2024

New issue template created in this repo. Disabled the tickets on the ldd-cassini repo

@matthewtiscareno
Copy link
Author

Okay, great. Checking to see whether old issues are preserved, I see now that

  • the former ldd-cassini issues 1, 2, 3, 6, 7, 8, 9, and 11 now are redirects to ldd-cassini pull requests with the same number, which is not necessarily correct,
  • the former ldd-cassini issue 4 is now a 404 page not found, and
  • the former ldd-cassini issues 5 and 10 are now redirects to (respectively) PDS4-LDD-Issue-Repo issues 311 and 312, which is correct.

Just checking whether all this is intended, @jordanpadams.

@jordanpadams
Copy link
Contributor

@matthewtiscareno

the former ldd-cassini issues pds-data-dictionaries/ldd-cassini#1, pds-data-dictionaries/ldd-cassini#2, pds-data-dictionaries/ldd-cassini#3, pds-data-dictionaries/ldd-cassini#6, pds-data-dictionaries/ldd-cassini#7, pds-data-dictionaries/ldd-cassini#8, pds-data-dictionaries/ldd-cassini#9, and pds-data-dictionaries/ldd-cassini#11 now are redirects to ldd-cassini pull requests with the same number, which is not necessarily correct,

This is actually expected. Pull requests are basically just a specialized Issue in GitHub system terms, so the numbers increment together.

the former ldd-cassini issue 4 is now a 404 page not found, and

I reopened the tickets and migrated this over to the issues repo

@matthewtiscareno
Copy link
Author

This is actually expected. Pull requests are basically just a specialized Issue in GitHub system terms, so the numbers increment together.

Ah, that explains something we were wondering about yesterday.

I reopened the tickets and migrated this over to the issues repo

Great. The former ldd-cassini issue 4 is now a redirect to (closed) PDS4-LDD-Issue-Repo issue 313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ldd-cassini Issue for ldd-cassini repository
Projects
Status: Done
Development

No branches or pull requests

2 participants