Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies missing #313

Open
2 tasks done
StijnKas opened this issue Jan 10, 2025 · 0 comments
Open
2 tasks done

Optional dependencies missing #313

StijnKas opened this issue Jan 10, 2025 · 0 comments
Labels
bug Something isn't working Python Issues related to the Python tools

Comments

@StijnKas
Copy link
Collaborator

pdstools version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pdstools.

Issue description

When running pdstools on a clean environment, great-tables & pandas seem to be required - even though they are optional. This is triggered from Reports and from the new IH class (pandas is in plotly.express in IH I think; let's inline dependency it just like ADM.plots)

Same for pyarrow; we still use the use_pyarrow_extension_array when we convert to pandas for some plotly charts - we don't need to do this now that plotly uses Narwhals

Reproducible example

from pdstools import datasets
datasets.cdh_sample()

Expected behavior

These optional dependencies should be optional - and not installed directly

Installed versions

Replace this line with the output of pdstools.show_versions(), leave the backticks in place
@StijnKas StijnKas added bug Something isn't working Python Issues related to the Python tools labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Issues related to the Python tools
Projects
None yet
Development

No branches or pull requests

1 participant