Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EventCategory::Unknown to Unspecified #364

Open
syncpark opened this issue Oct 21, 2024 · 2 comments
Open

Change EventCategory::Unknown to Unspecified #364

syncpark opened this issue Oct 21, 2024 · 2 comments

Comments

@syncpark
Copy link
Contributor

syncpark commented Oct 21, 2024

EventCategory is partially extracted and used from MITRE, and EventCategory::Unknown is a classification given to unconfirmed detection events.

Unspecified is a clearer expression than Unknown.

@msk
Copy link
Contributor

msk commented Oct 21, 2024

I understand your point about Unspecified being a clearer expression, but I'm not sure if introducing a new enum variant that's not part of the MITRE ATT&CK Framework is the best approach. If we're aiming to conform to the framework, adding a non-standard variant could lead to confusion.

Have you considered making the EventCategory field an Option instead? This would allow us to represent unassigned or unknown categories in a more idiomatic Rust way (i.e., None). This approach would also avoid deviating from the MITRE framework. What are your thoughts on this?

@syncpark
Copy link
Contributor Author

I agree with you.

After changing the category field to Option of all detected events, and in the Web UI, detection events with None category would be expressed as Unspecified.

However, this modification will takes some time. Maybe this can be included in the next product release.

@sehkone @sophie-cluml

What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants