Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort and black conflict #15

Closed
alessandro-canevaro opened this issue Jan 17, 2022 · 4 comments · Fixed by #18
Closed

isort and black conflict #15

alessandro-canevaro opened this issue Jan 17, 2022 · 4 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@alessandro-canevaro
Copy link
Collaborator

alessandro-canevaro commented Jan 17, 2022

I ran tox ./ (in the profiling branch) and isort wants to format the imports as

from torch.profiler import (ProfilerActivity, profile, record_function,
                            tensorboard_trace_handler)

while black as

from torch.profiler import (
    ProfilerActivity,
    profile,
    record_function,
    tensorboard_trace_handler,
)

therefore the code never passes the lint checks.

@alessandro-canevaro alessandro-canevaro added the bug Something isn't working label Jan 17, 2022
@peterampazzo
Copy link
Owner

wow 🤯

@peterampazzo
Copy link
Owner

please, push your changes so I can have a look

@alessandro-canevaro
Copy link
Collaborator Author

alessandro-canevaro commented Jan 17, 2022

it is pushed in the branch profiling
it is the src/profiling/mode_profiling.py file

@peterampazzo
Copy link
Owner

PyCQA/isort#1518 (comment)

This solution should solve the error.

@alessandro-canevaro alessandro-canevaro linked a pull request Jan 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants