Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logging.RotatingFileHandler] The RotatingFileHandler opens and closes file for each message #86

Open
PolarGoose opened this issue Jul 3, 2024 · 0 comments
Open

[logging.RotatingFileHandler] The RotatingFileHandler opens and closes file for each message #86

PolarGoose opened this issue Jul 3, 2024 · 0 comments

Comments

@PolarGoose
Copy link

Bug description
RotatingFileHandler logging handler opens and closes the log file for every message: line #61.

Proposal

  • Open the file once in the constructor.
  • Close the file only when rotation happens.
@PolarGoose PolarGoose changed the title [logging] The RotatingFileHandler opens and closes file for each message [logging.RotatingFileHandler] The RotatingFileHandler opens and closes file for each message Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PolarGoose