Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BiosampleConverter #55

Open
pnrobinson opened this issue Apr 21, 2022 · 1 comment
Open

BiosampleConverter #55

pnrobinson opened this issue Apr 21, 2022 · 1 comment

Comments

@pnrobinson
Copy link
Collaborator

@julesjacobsen given the lack of strictness in the semantics of version 1 variants, it seems it might be better to emit a warning here that the user will need an implementation specific way of doing this conversion?

if (biosample.getVariantsCount() != 0) {
     // TODO: create an interpretation along with any genes
}
@pnrobinson
Copy link
Collaborator Author

@ielis @julesjacobsen -- we could add this to the conversion and basically just assume that it is causal if people used it in V1 or we could emit a warning and skip things. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant