Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on Manjaro Linux. #1

Open
sjdevries opened this issue Nov 29, 2019 · 10 comments
Open

Tests failing on Manjaro Linux. #1

sjdevries opened this issue Nov 29, 2019 · 10 comments

Comments

@sjdevries
Copy link

I really like the look of the Polycore graph, but have been unable to get it to work. I have removed any of the nvidia / drive sections. I did not modify the core count, and have more than 6 cores, in case that makes a difference.

Linux version: 5.4.0-2-MANJARO (Manjaro Testing Branch)
Conky version: 1.11.3 (conky-lua from AUR)

conky -c test/test_util.lua

test clamp passed
test CycleQueue passed

conky -c test/test_layout.lua

test columns passed
test frame passed
test/test_layout.lua:58: render of at /tmp/conky_test.png does not match expected result at test/expected_outputs/complex_layout.png
stack traceback:
	test/test_layout.lua:190: in function 
	[C]: in function 'assert'
	test/test_layout.lua:58: in upvalue 'check_renderer'
	test/test_layout.lua:178: in function 
	[C]: in function 'xpcall'
	test/test_layout.lua:197: in function 'conky_update'
test complex_layout failed
test group passed

conky -c conkyrc.lua

conky: desktop window (400010) is subwindow of root window (6b4)
conky: window type - normal
conky: drawing to created window (0x2c00002)
conky: drawing to double buffer
./layout.lua:25: invalid value (nil) at index 3 in table for 'concat'
stack traceback:
	./src/polycore.lua:50: in function <./src/polycore.lua:49>
	[C]: in function 'table.concat'
	./layout.lua:25: in method 'update'
	./src/widget.lua:138: in method 'update'
	./src/polycore.lua:30: in function <./src/polycore.lua:25>
	[C]: in function 'xpcall'
	./src/polycore.lua:60: in function 'conky_update'

The stack traceback repeats every 1 second, which makes sense given the update timer.

Note: if I used window_type override I get a completely different error, but I think that is from this conky issue: brndnmtthws/conky#424

@philer
Copy link
Owner

philer commented Nov 29, 2019

Edited

Those seem to be two separate issues. I don't know what's causing the test to fail. I've pushed a small update for test_layout. If you don't mind, please pull that and run the test again, then upload the resulting file from /tmp/conky_test_complex_layout.png if the test still fails.

The normal layout fails in the fan rpm section, probably because you don't have lm_sensors installed or configured. Run sensors to see if any fans are reported. If the output does contain any fans please post it so I can check what's different.

I've added some comments in layout.lua to hopefully make those things easier to figure out.

@philer
Copy link
Owner

philer commented Dec 1, 2019

I worked on the tests some more. I assume that yours failed due to font rendering differences. Maybe you don't have the ubuntu font installed?

@philer philer added the needs info The issue needs new or additional information from the author. label Dec 1, 2019
@dagadark
Copy link

dagadark commented Dec 8, 2019

I passed the test_util with the output:

test CycleQueue_init passed
test CycleQueue_index passed
test clamp passed
test CycleQueue_put passed
test CycleQueue_ipairs passed

But error with test_layout:

test/../src/cairo_helpers.lua:136: attempt to call a nil value (global 'cairo_image_surface_create')
stack traceback:
	test/test_layout.lua:260: in global 'cairo_image_surface_create'
	test/../src/cairo_helpers.lua:136: in upvalue 'fn'
	test/../src/util.lua:50: in function 'src/cairo_helpers.font_extents'
	test/../src/widget.lua:479: in field 'init'
	test/../src/widget.lua:535: in method 'init'
	test/../src/util.lua:17: in field 'TextLine'
	test/test_layout.lua:142: in function <test/test_layout.lua:133>
	[C]: in function 'xpcall'
	test/test_layout.lua:267: in function 'conky_update'
test text failed
test/../src/widget.lua:76: attempt to call a nil value (global 'cairo_image_surface_create')
stack traceback:
	test/test_layout.lua:260: in global 'cairo_image_surface_create'
	test/../src/widget.lua:76: in method 'init'
	test/../src/util.lua:17: in field 'Renderer'
	test/test_layout.lua:120: in function <test/test_layout.lua:113>
	[C]: in function 'xpcall'
	test/test_layout.lua:267: in function 'conky_update'
test group failed
test/../src/widget.lua:76: attempt to call a nil value (global 'cairo_image_surface_create')
stack traceback:
	test/test_layout.lua:260: in global 'cairo_image_surface_create'
	test/../src/widget.lua:76: in method 'init'
	test/../src/util.lua:17: in field 'Renderer'
	test/test_layout.lua:110: in function <test/test_layout.lua:98>
	[C]: in function 'xpcall'
	test/test_layout.lua:267: in function 'conky_update'
test frame failed
test/../src/widget.lua:76: attempt to call a nil value (global 'cairo_image_surface_create')
stack traceback:
	test/test_layout.lua:260: in global 'cairo_image_surface_create'
	test/../src/widget.lua:76: in method 'init'
	test/../src/util.lua:17: in field 'Renderer'
	test/test_layout.lua:248: in function <test/test_layout.lua:187>
	[C]: in function 'xpcall'
	test/test_layout.lua:267: in function 'conky_update'
test complex_layout failed
test/../src/widget.lua:76: attempt to call a nil value (global 'cairo_image_surface_create')
stack traceback:
	test/test_layout.lua:260: in global 'cairo_image_surface_create'
	test/../src/widget.lua:76: in method 'init'
	test/../src/util.lua:17: in field 'Renderer'
	test/test_layout.lua:130: in function <test/test_layout.lua:123>
	[C]: in function 'xpcall'
	test/test_layout.lua:267: in function 'conky_update'
test columns failed

I have installed ubuntu font too.

@philer
Copy link
Owner

philer commented Dec 8, 2019

@dagadark Did you run the test via conky -c ? Which version of conky are you using?

@dagadark
Copy link

dagadark commented Dec 8, 2019

@philer I use conky v1.11.5 and I run the test via conky -c.

@philer
Copy link
Owner

philer commented Dec 8, 2019

Then I assume your conky build is missing the cairo bindings. If you run conky -v it should be listed under "Lua bindings:".

@dagadark
Copy link

dagadark commented Dec 8, 2019

@philer After rebuilding conky, i got another error:
conky -c test/test_layout.lua:

test columns passed
test/test_layout.lua:61: Render at '/tmp/conky_test_text.png' does not match expected result at 'test/expected_outputs/text.png'.
Image diff stored at '/tmp/conky_test_text_diff.png'.
stack traceback:
	test/test_layout.lua:260: in function <test/test_layout.lua:259>
	[C]: in function 'assert'
	test/test_layout.lua:61: in upvalue 'assert_images_equal'
	test/test_layout.lua:73: in upvalue 'check_renderer'
	test/test_layout.lua:184: in function <test/test_layout.lua:133>
	[C]: in function 'xpcall'
	test/test_layout.lua:267: in function 'conky_update'
test text failed
test complex_layout passed
test frame passed
test group passed

Updated:
The diff image
conky_test_text_diff
And I got the same error with @sjdevries when running conky -c conkyrc.lua

@philer
Copy link
Owner

philer commented Dec 8, 2019

Thanks for the image. I think it means that font rendering is inconsistent. Judging by the image the anti aliasing around the edges is different. There may not be a way to fix this. Could you upload the actual result image from /tmp as well?

For the other issue please refer to my first reply above.

@dagadark
Copy link

dagadark commented Dec 8, 2019

Text image result from /tmp: /tmp/conky_test_text
Text image result from /expected_outputs: /expected_outputs/text

@philer
Copy link
Owner

philer commented Dec 8, 2019

That font rendering does look considerably different. I'll have to investigate.
Thanks for your help!

@philer philer removed the needs info The issue needs new or additional information from the author. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants