-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site title breaks mobile menu when too long #18
Comments
Here is an example for the solution : http://ec2-52-8-95-16.us-west-1.compute.amazonaws.com:4567/ 1)Modifiy header.tpl in ~/node_modules/nodebb-theme-material/templates/menu.tpl Line 24: 2)Modify css class in ~/node_modules/nodebb-theme-material/less/header.less .forum-title { .forum-logo { @media only screen and (max-width: 600px) { |
@ralic The first problem with that solution is that you have the icons on the header removed on lower resolutions. My solution leaves those intact. Secondly, while reducing the font size is probably a good addition, it still won't solve the issue when the icons are present. By having it as a flex-box, it will adjust the width to be the remaining space after icons, and will use elipsis to show the user there wasn't enough room to show the entire title. See my PR: #21 |
Actuarially, I reduced the forum-logo and forum-title size responsively to smaller screen. |
@ralic I recognize that, but I do not agree that it's a complete solution. It doesn't fix every issue. I can break it by simply having a longer title. See below: |
I got your point. Collapsing the title or keep the title short might be the best idea :) |
This could be fixed by making the title clipped with ellipsis. I will make a PR later tonight.
The text was updated successfully, but these errors were encountered: