Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picketlink performance is too bad due to have unresonable lock. #165

Open
wzhx78 opened this issue Apr 19, 2013 · 2 comments
Open

Picketlink performance is too bad due to have unresonable lock. #165

wzhx78 opened this issue Apr 19, 2013 · 2 comments

Comments

@wzhx78
Copy link

wzhx78 commented Apr 19, 2013

when we test picketlink performance, we found the picketlink performance is very bad due to each of process have global lock in the code. e.g org.picketlink.identity.federation.web.process.SAMLHandlerChainProcessor. ServiceProviderBaseProcessor and org/picketlink/identity/federation/bindings/tomcat/idp/AbstractIDPValve. but we check the handler is thread safe, so the lock is unreasonable. we can remove this lock or change the hanlder not singletone.

we had tried to fix by our self. after remove unreasonable lock, the TPS will back to 456, one TPS include one login and one global logout.

please check our gist.

https://gist.github.com/wzhx78/5418959

@anilsaldhana
Copy link
Contributor

@pedroigor
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants